From bfc51d4acad3c580ad52d32ab969f76797566388 Mon Sep 17 00:00:00 2001 From: Thomas Fransolet Date: Thu, 25 Mar 2021 17:23:13 +0100 Subject: [PATCH] MC clean code --- MyCore/Services/Devices/ActionService.cs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/MyCore/Services/Devices/ActionService.cs b/MyCore/Services/Devices/ActionService.cs index b73a52a..02244b4 100644 --- a/MyCore/Services/Devices/ActionService.cs +++ b/MyCore/Services/Devices/ActionService.cs @@ -104,23 +104,23 @@ namespace MyCore.Services.Devices switch (action.Type) { case ActionType.DEVICE: - var zigbeeDeviceAction = _DeviceDatabaseService.GetById(action.DeviceId); + var deviceAction = _DeviceDatabaseService.GetById(action.DeviceId); var providerActionTest = _ProviderDatabaseService.GetById(userId, action.ProviderId); - DeviceNameForAction = zigbeeDeviceAction.Name; - actionDeviceToTest = zigbeeDeviceAction; - System.Console.WriteLine($"We get a zigbeeDeviceAction ! Name={zigbeeDeviceAction.Name} Type={zigbeeDeviceAction.Type}"); + DeviceNameForAction = deviceAction.Name; + actionDeviceToTest = deviceAction; + System.Console.WriteLine($"We get a device action ! Name={deviceAction.Name} Type={deviceAction.Type}"); System.Console.WriteLine($"Check action provider type ! Type={providerActionTest.Type} Name={providerActionTest.Name}"); break; case ActionType.GROUP: - var zigbeeGroupAction = _GroupDatabaseService.GetById(action.GroupId); - DeviceNameForAction = zigbeeGroupAction.Name; + var groupAction = _GroupDatabaseService.GetById(action.GroupId); + DeviceNameForAction = groupAction.Name; - System.Console.WriteLine($"We get a zigbeeGroupAction ! Name={zigbeeGroupAction.Name} Type={zigbeeGroupAction.Type}"); - System.Console.WriteLine($"Check action zigbeeGroupAction type ! Type={zigbeeGroupAction.Type}"); + System.Console.WriteLine($"We get a group action ! Name={groupAction.Name} Type={groupAction.Type}"); + System.Console.WriteLine($"Check action zigbeeGroupAction type ! Type={groupAction.Type}"); // Check state of first device of a group - actionDeviceToTest = _DeviceDatabaseService.GetByGroup(zigbeeGroupAction.Id).FirstOrDefault(); // TODO : Send error if no device found ! + actionDeviceToTest = _DeviceDatabaseService.GetByGroup(groupAction.Id).FirstOrDefault(); // TODO : Send error if no device found ! break; case ActionType.MQTT: // take raw request and send it !