Ingestion et indexation
- IIngestionService/IngestionService : chargement des collections filles par
sous-type, un jeu de morceaux par langue, ChunkIndex continu.
- SectionIndexingInterceptor retenu comme unique déclencheur : les 5
sous-contrôleurs totalisaient 30 SaveChanges et 0 Enqueue, donc ajouter des
points d'intérêt à une carte ne réindexait rien.
- HTML retiré avant l'embedding et lignes trop longues recoupées : sans cela un
article dépassait l'entrée max du modèle et emportait son lot de 50 morceaux.
- Gabarits de LanguageInit filtrés, DistinctBy(Text) avant le Take : ils
occupaient les cinq premiers résultats d'une recherche en néerlandais.
Endpoints du guide IA
- GET /api/Ai/knowledge/{id} : agrégats sur ContentEmbedding, donc sur ce qui
est réellement indexé — compter les sections publiées serait plus flatteur et faux.
- GET /api/Ai/insights/{id} : miroir de GuideIaInsights côté manager-app, c'est
l'écran qui a fixé la forme pour que le job de thèmes la remplisse.
RGPD
- VisitorQuestion journalisée dans AiController.Chat. HasAnswer se déduit des
sources du retrieval, pas du texte : un repli poli ressemble à une réponse.
L'écriture n'échoue jamais la réponse au visiteur.
- VisitorQuestionPurgeService, 90 jours, actif sans condition de configuration :
une durée écrite dans les CGU n'est pas un réglage commercial.
Corrections
- Updateinstance ne recopiait pas les quotas du nouveau plan.
- CheckQuota ne bloquait ni ne comptait à quota 0 — IA gratuite non comptée.
- StoragePath et SizeBytes renseignés à Create, types URL exclus.
dotnet build 0 erreur, dotnet test 130/130.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
239 lines
9.8 KiB
C#
239 lines
9.8 KiB
C#
using ManagerService.Controllers;
|
|
using ManagerService.Data;
|
|
using ManagerService.DTOs;
|
|
using ManagerService.Services;
|
|
using ManagerService.Tests.Infrastructure;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Hangfire;
|
|
using Moq;
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Xunit;
|
|
|
|
namespace ManagerService.Tests.Controllers
|
|
{
|
|
public class AiControllerTests
|
|
{
|
|
private static readonly AiChatResponse FakeResponse = new AiChatResponse { Reply = "OK", TokensUsed = 42 };
|
|
|
|
// Chat vérifie les droits de l'appelant (IsSuperAdmin / instance du token) :
|
|
// sans utilisateur, User est null et le contrôleur renvoie un 500.
|
|
private AiController BuildController(MyInfoMateDbContext db, Mock<IAssistantService>? mockService = null,
|
|
string callerRole = Permissions.SuperAdmin, string callerInstanceId = "i1")
|
|
{
|
|
mockService ??= new Mock<IAssistantService>();
|
|
mockService
|
|
.Setup(s => s.ChatAsync(It.IsAny<AiChatRequest>()))
|
|
.ReturnsAsync(FakeResponse);
|
|
|
|
var controller = new AiController(mockService.Object, db, NullLogger<AiController>.Instance,
|
|
new Mock<IBackgroundJobClient>().Object);
|
|
FakeUser.SetUser(controller, FakeUser.Create(callerRole, callerInstanceId));
|
|
return controller;
|
|
}
|
|
|
|
private static AiChatRequest MakeRequest(string instanceId, AppType appType = AppType.Tablet) =>
|
|
new AiChatRequest { InstanceId = instanceId, AppType = appType, Message = "Bonjour" };
|
|
|
|
// ── FORBID CASES ─────────────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public async Task Chat_InstanceNotFound_ReturnsForbid()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
|
|
var result = await BuildController(db).Chat(MakeRequest("unknown"));
|
|
|
|
Assert.IsType<ForbidResult>(result);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Chat_InstanceAssistantDisabled_ReturnsForbid()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = false, DateCreation = DateTime.UtcNow
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = true,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
var result = await BuildController(db).Chat(MakeRequest("i1"));
|
|
|
|
Assert.IsType<ForbidResult>(result);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Chat_AppInstanceAssistantDisabled_ReturnsForbid()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = false,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
var result = await BuildController(db).Chat(MakeRequest("i1"));
|
|
|
|
Assert.IsType<ForbidResult>(result);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Chat_NoAppInstance_ReturnsForbid()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow
|
|
});
|
|
db.SaveChanges();
|
|
|
|
var result = await BuildController(db).Chat(MakeRequest("i1"));
|
|
|
|
Assert.IsType<ForbidResult>(result);
|
|
}
|
|
|
|
// ── QUOTA COUNTER ────────────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public async Task Chat_FirstRequestOfMonth_ResetsCounterAndAddsTokensUsed()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow,
|
|
AiTokensThisMonth = 99, AiTokensPerMonth = 1_000, AiUsageMonthKey = "2020-01"
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = true,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
await BuildController(db).Chat(MakeRequest("i1"));
|
|
|
|
var inst = db.Instances.First();
|
|
Assert.Equal(42, inst.AiTokensThisMonth);
|
|
Assert.Equal(DateTime.UtcNow.ToString("yyyy-MM"), inst.AiUsageMonthKey);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Chat_SameMonth_AddsTokensUsedToCounter()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
var monthKey = DateTime.UtcNow.ToString("yyyy-MM");
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow,
|
|
AiTokensThisMonth = 3, AiTokensPerMonth = 1_000, AiUsageMonthKey = monthKey
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = true,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
await BuildController(db).Chat(MakeRequest("i1"));
|
|
|
|
Assert.Equal(45, db.Instances.First().AiTokensThisMonth);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Chat_QuotaAlreadyReached_ReturnsTooManyRequestsWithoutCallingAssistantService()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
var monthKey = DateTime.UtcNow.ToString("yyyy-MM");
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow,
|
|
AiTokensThisMonth = 100, AiTokensPerMonth = 100, AiUsageMonthKey = monthKey
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = true,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
var mockService = new Mock<IAssistantService>();
|
|
mockService.Setup(s => s.ChatAsync(It.IsAny<AiChatRequest>())).ReturnsAsync(FakeResponse);
|
|
|
|
var result = await BuildController(db, mockService).Chat(MakeRequest("i1"));
|
|
|
|
var status = Assert.IsType<ObjectResult>(result);
|
|
Assert.Equal(429, status.StatusCode);
|
|
mockService.Verify(s => s.ChatAsync(It.IsAny<AiChatRequest>()), Times.Never);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Chat_PlanWithoutAi_ReturnsForbiddenWithoutCallingAssistantService()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
db.Instances.Add(new Instance
|
|
{
|
|
// AiTokensPerMonth à 0 = pas d'IA dans le plan, et surtout pas « illimité » :
|
|
// c'est l'état de plan-starter et de toute instance fraîchement migrée.
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow,
|
|
AiTokensPerMonth = 0, AiUsageMonthKey = DateTime.UtcNow.ToString("yyyy-MM")
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = true,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
var mockService = new Mock<IAssistantService>();
|
|
mockService.Setup(s => s.ChatAsync(It.IsAny<AiChatRequest>())).ReturnsAsync(FakeResponse);
|
|
|
|
var result = await BuildController(db, mockService).Chat(MakeRequest("i1"));
|
|
|
|
var status = Assert.IsType<ObjectResult>(result);
|
|
Assert.Equal(403, status.StatusCode);
|
|
mockService.Verify(s => s.ChatAsync(It.IsAny<AiChatRequest>()), Times.Never);
|
|
}
|
|
|
|
// ── NOMINAL ──────────────────────────────────────────────────────────
|
|
|
|
[Fact]
|
|
public async Task Chat_Success_CallsAssistantServiceAndReturns200()
|
|
{
|
|
using var db = DbContextFactory.Create();
|
|
var mockService = new Mock<IAssistantService>();
|
|
mockService.Setup(s => s.ChatAsync(It.IsAny<AiChatRequest>())).ReturnsAsync(FakeResponse);
|
|
|
|
db.Instances.Add(new Instance
|
|
{
|
|
Id = "i1", Name = "Musée", IsAssistant = true, DateCreation = DateTime.UtcNow,
|
|
AiTokensPerMonth = 1_000, AiUsageMonthKey = DateTime.UtcNow.ToString("yyyy-MM")
|
|
});
|
|
db.ApplicationInstances.Add(new ApplicationInstance
|
|
{
|
|
Id = "ai1", InstanceId = "i1", AppType = AppType.Tablet, IsAssistant = true,
|
|
Languages = new List<string>()
|
|
});
|
|
db.SaveChanges();
|
|
|
|
var result = await BuildController(db, mockService).Chat(MakeRequest("i1"));
|
|
|
|
var ok = Assert.IsType<OkObjectResult>(result);
|
|
Assert.Equal(FakeResponse, ok.Value);
|
|
mockService.Verify(s => s.ChatAsync(It.IsAny<AiChatRequest>()), Times.Once);
|
|
}
|
|
}
|
|
}
|